Messages in this thread | | | Date | Thu, 21 Jul 2022 23:55:40 +0900 | From | Masami Hiramatsu (Google) <> | Subject | Re: [PATCH] selftests/kprobe: Update test for no event name syntax error |
| |
On Mon, 18 Jul 2022 17:36:43 +0800 Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
> hi Masami, > > On 7/18/2022 3:05 PM, Masami Hiramatsu (Google) wrote: > > From: Masami Hiramatsu (Google) <mhiramat@kernel.org> > > > > The commit 208003254c32 ("selftests/kprobe: Do not test for GRP/ > > without event failures") removed a syntax which is no more cause > > a syntax error (NO_EVENT_NAME error with GRP/). > > However, there are another case (NO_EVENT_NAME error without GRP/) > > which causes a same error. This adds a test for that case. > > > > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> > > --- > > .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > > index 7c02509c71d0..9e85d3019ff0 100644 > > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > > @@ -21,6 +21,7 @@ check_error 'p:^/bar vfs_read' # NO_GROUP_NAME > > check_error 'p:^12345678901234567890123456789012345678901234567890123456789012345/bar vfs_read' # GROUP_TOO_LONG > > > > check_error 'p:^foo.1/bar vfs_read' # BAD_GROUP_NAME > > +check_error 'p:^ vfs_read' # NO_EVENT_NAME > > i think you fix the issue which exist from start, right ?
Yes, this is not a new bug but the error case which still exists.
> > is there better comment than NO_EVENT_NAME ?
These comments are corresponding to the error name, so that we can find the logging code easily. (Not for users)
Thank you,
> > > check_error 'p:foo/^12345678901234567890123456789012345678901234567890123456789012345 vfs_read' # EVENT_TOO_LONG > > check_error 'p:foo/^bar.1 vfs_read' # BAD_EVENT_NAME > > > >
-- Masami Hiramatsu (Google) <mhiramat@kernel.org>
| |