lkml.org 
[lkml]   [2022]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the coverity warning
Date
> -----Original Message-----
> From: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Sent: Tuesday, May 24, 2022 1:19 PM
> To: vkoul@kernel.org; Michal Simek <michals@xilinx.com>;
> m.tretter@pengutronix.de
> Cc: dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org;
> git@amd.com; Shravya Kumbham <shravyak@xlnx.xilinx.com>; Harini
> Katakam <harinik@xilinx.com>; Radhey Shyam Pandey
> <radhey.shyam.pandey@amd.com>
> Subject: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the
> coverity warning
>
> From: Shravya Kumbham <shravya.kumbham@xilinx.com>
>
> Typecast the flags variable with (enum dma_ctrl_flags) in
> zynqmp_dma_prep_memcpy function to fix the coverity warning.
>
> Addresses-Coverity: Event mixed_enum_type.
> Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
> NOTE- This patch was sent to dmaengine mailing list[1] and
> there was a suggestion from Michael Tretter to change the
> signature of the dmaengine_prep_dma_memcpy() engine to accept
> "enum dma_ctrl_flags flags" instead of "unsigned long flags".
>
> All device_prep_dma_* API variants have ulong flags argument.
> So this is a wider question if we want to change these APIs?
> Also there are existing users of these public APIs.
>
> [1]: https://lore.kernel.org/linux-arm-kernel/20210914082817.22311-2-
> harini.katakam@xilinx.com/t/#m1d1bc959f500b04fa1470caa31239a95c73fd
> 45d
> ---
> drivers/dma/xilinx/zynqmp_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c
> b/drivers/dma/xilinx/zynqmp_dma.c
> index dc299ab36818..3f4ee3954384 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -849,7 +849,7 @@ static struct dma_async_tx_descriptor
> *zynqmp_dma_prep_memcpy(
>
> zynqmp_dma_desc_config_eod(chan, desc);
> async_tx_ack(&first->async_tx);
> - first->async_tx.flags = flags;
> + first->async_tx.flags = (enum dma_ctrl_flags)flags;
> return &first->async_tx;
> }
>
> --
Ping! for review.

\
 
 \ /
  Last update: 2022-07-21 16:25    [W:0.982 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site