Messages in this thread | | | Date | Thu, 21 Jul 2022 19:06:19 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 1/2] dmaengine: xilinx_dma: Fix probe error cleanup |
| |
On 12-07-22, 07:36, Agarwal, Swati wrote: > Hi Vinod, > > > -----Original Message----- > > From: Vinod Koul <vkoul@kernel.org> > > Sent: Friday, July 1, 2022 5:21 PM > > To: Swati Agarwal <swati.agarwal@xilinx.com> > > Cc: lars@metafoo.de; adrianml@alumnos.upm.es; libaokun1@huawei.com; > > marex@denx.de; dmaengine@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > > harini.katakam@xilinx.com; radhey.shyam.pandey@xilinx.com; > > michal.simek@xilinx.com > > Subject: Re: [PATCH 1/2] dmaengine: xilinx_dma: Fix probe error cleanup > > > > CAUTION: This message has originated from an External Source. Please use > > proper judgment and caution when opening attachments, clicking links, or > > responding to this email. > > > > > > On 24-06-22, 12:05, Swati Agarwal wrote: > > > When probe fails remove dma channel resources and disable clocks in > > > accordance with the order of resources allocated . > > > > Ok this looks fine and the changes below.. > > Thanks for the review!! > Sorry for the delayed reply. I missed this mail due to some mailer issues. > > > > > > > Add missing cleanup in devm_platform_ioremap_resource(), > > > xlnx,num-fstores property. > > > > Where is this part? > > The statement is an elaboration of the previous one. The relevant code is below.
Okay, a patch should do only One thing, pls consider splitting it up...
> > <snip> > > > /* Request and map I/O memory */ > > > xdev->regs = devm_platform_ioremap_resource(pdev, 0); > > > - if (IS_ERR(xdev->regs)) > > > - return PTR_ERR(xdev->regs); > > > + if (IS_ERR(xdev->regs)) { > > > + err = PTR_ERR(xdev->regs); > > > + goto disable_clks; > > > + } > > This > > <snip> > > > if (err < 0) { > > > dev_err(xdev->dev, > > > "missing xlnx,num-fstores property\n"); > > > - return err; > > > + goto disable_clks; > > > } > > And this > > Regards, > Swati Agarwal
-- ~Vinod
| |