| From | Camelia Alexandra Groza <> | Subject | RE: [PATCH net-next v3 38/47] net: dpaa: Adjust queue depth on rate change | Date | Thu, 21 Jul 2022 13:18:49 +0000 |
| |
> -----Original Message----- > From: Linuxppc-dev <linuxppc-dev- > bounces+camelia.groza=nxp.com@lists.ozlabs.org> On Behalf Of Sean > Anderson > Sent: Saturday, July 16, 2022 1:00 > To: David S . Miller <davem@davemloft.net>; Jakub Kicinski > <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>; > netdev@vger.kernel.org > Cc: Leo Li <leoyang.li@nxp.com>; Sean Anderson > <sean.anderson@seco.com>; Russell King <linux@armlinux.org.uk>; linux- > kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>; Paolo > Abeni <pabeni@redhat.com>; linuxppc-dev@lists.ozlabs.org; linux-arm- > kernel@lists.infradead.org > Subject: [PATCH net-next v3 38/47] net: dpaa: Adjust queue depth on rate > change > > Instead of setting the queue depth once during probe, adjust it on the > fly whenever we configure the link. This is a bit unusal, since usually > the DPAA driver calls into the FMAN driver, but here we do the opposite. > We need to add a netdev to struct mac_device for this, but it will soon > live in the phylink config. > > I haven't tested this extensively, but it doesn't seem to break > anything. We could possibly optimize this a bit by keeping track of the > last rate, but for now we just update every time. 10GEC probably doesn't > need to call into this at all, but I've added it for consistency. > > Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Acked-by: Camelia Groza <camelia.groza@nxp.com>
|