| From | Camelia Alexandra Groza <> | Subject | RE: [PATCH net-next v3 33/47] net: fman: Clean up error handling | Date | Thu, 21 Jul 2022 13:06:43 +0000 |
| |
> -----Original Message----- > From: Sean Anderson <sean.anderson@seco.com> > Sent: Saturday, July 16, 2022 1:00 > To: David S . Miller <davem@davemloft.net>; Jakub Kicinski > <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>; > netdev@vger.kernel.org > Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet > <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell > King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson > <sean.anderson@seco.com> > Subject: [PATCH net-next v3 33/47] net: fman: Clean up error handling > > This removes the _return label, since something like > > err = -EFOO; > goto _return; > > can be replaced by the briefer > > return -EFOO; > > Additionally, this skips going to _return_of_node_put when dev_node has > already been put (preventing a double put). > > Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Acked-by: Camelia Groza <camelia.groza@nxp.com>
|