lkml.org 
[lkml]   [2022]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH net-next v3 29/47] net: fman: Map the base address once
    Date
    > -----Original Message-----
    > From: Sean Anderson <sean.anderson@seco.com>
    > Sent: Saturday, July 16, 2022 1:00
    > To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
    > <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
    > netdev@vger.kernel.org
    > Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
    > <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
    > King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson
    > <sean.anderson@seco.com>
    > Subject: [PATCH net-next v3 29/47] net: fman: Map the base address once
    >
    > We don't need to remap the base address from the resource twice (once in
    > mac_probe() and again in set_fman_mac_params()). We still need the
    > resource to get the end address, but we can use a single function call
    > to get both at once.
    >
    > While we're at it, use platform_get_mem_or_io and
    > devm_request_resource
    > to map the resource. I think this is the more "correct" way to do things
    > here, since we use the pdev resource, instead of creating a new one.
    > It's still a bit tricy, since we need to ensure that the resource is a

    *tricky* typo

    > child of the fman region when it gets requested.
    >
    > Signed-off-by: Sean Anderson <sean.anderson@seco.com>

    Acked-by: Camelia Groza <camelia.groza@nxp.com>

    \
     
     \ /
      Last update: 2022-07-21 15:06    [W:4.138 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site