| From | Camelia Alexandra Groza <> | Subject | RE: [PATCH net-next v3 20/47] net: fman: Store initialization function in match data | Date | Thu, 21 Jul 2022 12:51:21 +0000 |
| |
> -----Original Message----- > From: Sean Anderson <sean.anderson@seco.com> > Sent: Saturday, July 16, 2022 0:59 > To: David S . Miller <davem@davemloft.net>; Jakub Kicinski > <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>; > netdev@vger.kernel.org > Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet > <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell > King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson > <sean.anderson@seco.com> > Subject: [PATCH net-next v3 20/47] net: fman: Store initialization function in > match data > > Instead of re-matching the compatible string in order to determine the > init function, just store it in the match data. This also move the setting > of the rest of the functions into init as well.
This last sentence can be rephrased to be clearer. Maybe something like: The separate setup functions aren't needed anymore. Merge their content into init as well.
> To ensure everything > compiles correctly, we move them to the bottom of the file. > > Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Acked-by: Camelia Groza <camelia.groza@nxp.com>
|