Messages in this thread | | | Date | Thu, 21 Jul 2022 09:49:47 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH v5] amba: Remove deferred device addition |
| |
On Wed, Jul 20, 2022 at 02:12:21PM +0100, Sudeep Holla wrote: > On Tue, Jul 19, 2022 at 11:20:10AM -0700, Saravana Kannan wrote: > > The uevents generated for an amba device need PID and CID information > > that's available only when the amba device is powered on, clocked and > > out of reset. So, if those resources aren't available, the information > > can't be read to generate the uevents. To workaround this requirement, > > if the resources weren't available, the device addition was deferred and > > retried periodically. > > > > However, this deferred addition retry isn't based on resources becoming > > available. Instead, it's retried every 5 seconds and causes arbitrary > > probe delays for amba devices and their consumers. > > > > Also, maintaining a separate deferred-probe like mechanism is > > maintenance headache. > > > > With this commit, instead of deferring the device addition, we simply > > defer the generation of uevents for the device and probing of the device > > (because drivers needs PID and CID to match) until the PID and CID > > information can be read. This allows us to delete all the amba specific > > deferring code and also avoid the arbitrary probing delays. > > > > Cc: Rob Herring <robh@kernel.org> > > Cc: Ulf Hansson <ulf.hansson@linaro.org> > > Cc: Saravana Kannan <saravanak@google.com> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > Tested-by: Sudeep Holla <sudeep.holla@arm.com> > > on Juno with linux-next(which had the reported issue [1]) + this patch(which > fixes the issue)
Ok, but this patch needs to end up in the patch system for me to apply it. Can someone please add "KernelVersion: 5.19-rc7" or whatever version the patch was generated against (just the tagged version is sufficient) somewhere in the email, and send it to patches@armlinu.org.uk.
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |