lkml.org 
[lkml]   [2022]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[RFC PATCH] mm: set cache_trim_mode when inactive ratio is undesired
Date
From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>

Undesirable inactive file ratio could be observed under some scenarios(such as
large number of mapped file access) and hardly recover during a certain period
of time, which could be a result of tight criteria judgement of cache_trim_mode,
which demand both of none-thrashing and inactive_is_low simutaneously and lead
to the mode as SCAN_FRAC or SCAN_EQUAL when scanning lru.

Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
mm/vmscan.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index f7d9a68..8e84fe6 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2663,6 +2663,23 @@ static bool inactive_is_low(struct lruvec *lruvec, enum lru_list inactive_lru)
return inactive * inactive_ratio < active;
}

+static bool inactive_is_high(struct lruvec *lruvec, enum lru_list inactive_lru)
+{
+ enum lru_list active_lru = inactive_lru + LRU_ACTIVE;
+ unsigned long inactive, active;
+ unsigned long active_ratio = 2;
+ unsigned long gb;
+
+ inactive = lruvec_page_state(lruvec, NR_LRU_BASE + inactive_lru);
+ active = lruvec_page_state(lruvec, NR_LRU_BASE + active_lru);
+
+ gb = (inactive + active) >> (30 - PAGE_SHIFT);
+ if (gb)
+ active_ratio = 1;
+
+ return inactive > active_ratio * active;
+}
+
enum scan_balance {
SCAN_EQUAL,
SCAN_FRACT,
@@ -3198,7 +3215,8 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc)
* anonymous pages.
*/
file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE);
- if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE))
+ if (file >> sc->priority && (!(sc->may_deactivate & DEACTIVATE_FILE)
+ || inactive_is_high(target_lruvec, LRU_INACTIVE_FILE)))
sc->cache_trim_mode = 1;
else
sc->cache_trim_mode = 0;
--
1.9.1
\
 
 \ /
  Last update: 2022-07-21 09:09    [W:0.038 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site