Messages in this thread | | | Date | Thu, 21 Jul 2022 19:43:17 -0700 | From | Jaegeuk Kim <> | Subject | Re: [PATCH] f2fs: modify task name prefix |
| |
On 07/18, Guowei Du wrote: > From: duguowei <duguowei@xiaomi.com> > > If there are more than one f2fs sbi, there will be more > discard threads. But the comm is too long to show dev > minor. So, change the default prefix of thread from > "f2fs_discard" to "f2fs_dcd".
That looks quite unreadable. What about unmap?
> > Before: > $ ps -e | grep f2fs > 1628 ? 00:00:00 f2fs_ckpt-7:10 > 1629 ? 00:00:00 f2fs_flush-7:10 > 1630 ? 00:00:00 f2fs_discard-7: > 1631 ? 00:00:00 f2fs_gc-7:10 > 2030 ? 00:00:00 f2fs_ckpt-7:27 > 2031 ? 00:00:00 f2fs_flush-7:27 > 2032 ? 00:00:00 f2fs_discard-7: > 2033 ? 00:00:00 f2fs_gc-7:27 > > After: > $ ps -e | grep f2fs > 1628 ? 00:00:00 f2fs_ckpt-7:10 > 1629 ? 00:00:00 f2fs_flush-7:10 > 1630 ? 00:00:00 f2fs_dcd-7:10 > 1631 ? 00:00:00 f2fs_gc-7:10 > 2030 ? 00:00:00 f2fs_ckpt-7:27 > 2031 ? 00:00:00 f2fs_flush-7:27 > 2032 ? 00:00:00 f2fs_dcd-7:27 > 2033 ? 00:00:00 f2fs_gc-7:27 > > Signed-off-by: duguowei <duguowei@xiaomi.com> > --- > fs/f2fs/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 874c1b9c41a2..2eeefcbe62db 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -2018,7 +2018,7 @@ int f2fs_start_discard_thread(struct f2fs_sb_info *sbi) > return 0; > > dcc->f2fs_issue_discard = kthread_run(issue_discard_thread, sbi, > - "f2fs_discard-%u:%u", MAJOR(dev), MINOR(dev)); > + "f2fs_dcd-%u:%u", MAJOR(dev), MINOR(dev)); > if (IS_ERR(dcc->f2fs_issue_discard)) > err = PTR_ERR(dcc->f2fs_issue_discard); > > -- > 2.36.1
| |