lkml.org 
[lkml]   [2022]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 3/3] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 (SM-T530)
From


On 22.07.2022 01:02, Matti Lehtimäki wrote:
> Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T530) wifi tablet
> based on the apq8026 platform.
>
> Currently supported are accelerometer sensor, hall sensor,
> internal storage, physical buttons (power & volume), screen
> (based on simple-framebuffer set up by the bootloader) sdcard,
> touchscreen and USB.
>
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
> ---
> Changes in v2:
> - Change codename to matisse-wifi
> - Remove msm-id, not needed when lk2nd is used
> - Remove unused labels from reserved memory regions
> - Rename muic node
> ---
> arch/arm/boot/dts/Makefile | 1 +
> .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 469 ++++++++++++++++++
> 2 files changed, 470 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 5112f493f494..8bac4f4f8656 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1010,6 +1010,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-apq8016-sbc.dtb \
> qcom-apq8026-asus-sparrow.dtb \
> qcom-apq8026-lg-lenok.dtb \
> + qcom-apq8026-samsung-matisse-wifi.dtb \
> qcom-apq8060-dragonboard.dtb \
> qcom-apq8064-cm-qs600.dtb \
> qcom-apq8064-ifc6410.dtb \
> diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> new file mode 100644
> index 000000000000..621e0a337724
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> @@ -0,0 +1,469 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2022, Matti Lehtimäki <matti.lehtimaki@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226.dtsi"
> +#include "qcom-pm8226.dtsi"
> +#include <dt-bindings/input/input.h>
Hello!

I think generally dt-bindings includes go before the DTS ones.
> +
> +/delete-node/ &smem_region;
> +
> +/ {
> + model = "Samsung Galaxy Tab 4 10.1";
> + compatible = "samsung,matisse-wifi", "qcom,apq8026";

[...]

> +
> +&sdhc_2 {
> + status = "okay";
> +
> + vmmc-supply = <&pm8226_l18>;
> + vqmmc-supply = <&pm8226_l21>;
> +
> + bus-width = <8>;
I doubt this.. do you have downstream backing this up?

> + cd-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
> +};

Other than that, this looks good to me.

Konrad

\
 
 \ /
  Last update: 2022-07-22 01:58    [W:0.059 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site