lkml.org 
[lkml]   [2022]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] microblaze: Fix typo in comment
From

Hey Slark,
On the list we reply "inline" rather than at the top of the
quoted email. This makes things easier to follow.
I fixed up your reply, see below ;)

On 21/07/2022 07:43, Slark Xiao wrote:
>
> At 2022-07-21 14:33:32, "Conor Dooley" <mail@conchuod.ie> wrote:
>>
>> On 21/07/2022 03:51, Slark Xiao wrote:
>>> Fix typo in the comment
>>>
>>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>>> ---
>>> arch/microblaze/kernel/entry.S | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/microblaze/kernel/entry.S b/arch/microblaze/kernel/entry.S
>>> index b179f8f6d287..8651fe351276 100644
>>> --- a/arch/microblaze/kernel/entry.S
>>> +++ b/arch/microblaze/kernel/entry.S
>>> @@ -456,7 +456,7 @@ TRAP_return: /* Make global symbol for debugging */
>>>
>>>
>>> /* This the initial entry point for a new child thread, with an appropriate
>>> - stack in place that makes it look the the child is in the middle of an
>>> + stack in place that makes it look the child is in the middle of an
>>
>> This is /a/ fix, but I don't think it is the right one for this comment.
>> Surely this should be "s/the the/like the/, no?
>
> Thanks for your reply.
> Actually I didn't get your point of 'Surely this should be "s/the the/like the/, no?'.
> Do you mean this is NOT a TYPO, but like a change which we use 'the/' instead of 'the the/'?

What I meant was that the sentence does not make very much sense, either now
or with your patch applied. I do think that "the the" is a mistake, but to me
the correct fix is replacing it with "like the" rather than "the".
The new sentence would read:
"stack in place that makes it look like the child is in the middle of an"

Oh, also - there's another typo in this line. "an syscall" should be "a syscall".
Thanks,
Conor.

>
> Thanks!
>>
>>> syscall. This function is actually `returned to' from switch_thread
>>> (copy_thread makes ret_from_fork the return address in each new thread's
>>> saved context). */

\
 
 \ /
  Last update: 2022-07-21 08:53    [W:0.070 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site