Messages in this thread | | | Date | Thu, 21 Jul 2022 08:44:18 +0200 | Subject | Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description | From | Krzysztof Kozlowski <> |
| |
On 21/07/2022 02:06, William Zhang wrote: > Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add > generic 4908 board entry.
This does not explain at all why you are doing it. Improve your commit messages.
The explanation you gave here: https://lore.kernel.org/all/b8eda882-6838-ab7d-6e2e-131e3125b16f@broadcom.com/ is also not really sufficient (and is not in commit msg). Moving things around in Linux Kconfig does not justify adding some new compatibles.
To be - clear - this is not a review, so you cannot add Rb tag. If you insist on a tag, then it as counted as NAK.
Best regards, Krzysztof
| |