lkml.org 
[lkml]   [2022]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/3] dt-bindings: clock: add SM6375 QCOM global clock bindings
From


On 20.07.2022 08:27, Krzysztof Kozlowski wrote:
> On 19/07/2022 13:57, Konrad Dybcio wrote:
>> Add device tree bindings for global clock controller for SM6375 SoCs.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>> ---
>> Changes since v1:
>> - dropped clock-names (switched to .index)
>>
>> .../bindings/clock/qcom,sm6375-gcc.yaml | 65 +++++
>> include/dt-bindings/clock/qcom,sm6375-gcc.h | 234 ++++++++++++++++++
>> 2 files changed, 299 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml
>> create mode 100644 include/dt-bindings/clock/qcom,sm6375-gcc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml
>> new file mode 100644
>> index 000000000000..2e43cd75d3d4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml
>> @@ -0,0 +1,65 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,sm6375-gcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Global Clock & Reset Controller Binding for SM6375
>> +
>> +maintainers:
>> + - Konrad Dybcio <konrad.dybcio@somainline.org>
>> +
>> +description: |
>> + Qualcomm global clock control module which supports the clocks, resets and
>> + power domains on SM6375
>> +
>> + See also:
>> + - dt-bindings/clock/qcom,sm6375-gcc.h
>> +
>
> Why you are not referencing qcom,gcc.yaml?
Hm.. Out of all the SoCs we support, only apq8084 and apq/ipq8064 reference it..
Should I add that?

Konrad


>
>> +properties:
>> + compatible:
>> + const: qcom,sm6375-gcc
>> +
>> + clocks:
>> + items:
>> + - description: Board XO source
>> + - description: Board XO Active-Only source
>> + - description: Sleep clock source
>> +
>> + '#clock-cells':
>> + const: 1
>> +
>> + '#reset-cells':
>> + const: 1
>> +
>> + '#power-domain-cells':
>> + const: 1
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - '#clock-cells'
>> + - '#reset-cells'
>> + - '#power-domain-cells'
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/qcom,rpmcc.h>
>> + clock-controller@1400000 {
>> + compatible = "qcom,sm6375-gcc";
>> + reg = <0x01400000 0x1f0000>;
>> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>,
>> + <&rpmcc RPM_SMD_XO_A_CLK_SRC>,
>> + <&sleep_clk>;
>> + #clock-cells = <1>;
>> + #reset-cells = <1>;
>> + #power-domain-cells = <1>;
>> + };
>> +
>> +...
>> diff --git a/include/dt-bindings/clock/qcom,sm6375-gcc.h b/include/dt-bindings/clock/qcom,sm6375-gcc.h
>> new file mode 100644
>> index 000000000000..1e9801e1cedf
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/qcom,sm6375-gcc.h
>> @@ -0,0 +1,234 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>
> Hm, Qualcomm gave permission to relicense bindings to dual-license,
> although I am not sure how this works with files where copyrights were
> transferred to Linux Foundation...
>
>> +/*
>> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2022, Konrad Dybcio <konrad.dybcio@somainline.org>
>> + */
>> +
>> +#ifndef _DT_BINDINGS_CLK_QCOM_GCC_SM6375_H
>> +#define _DT_BINDINGS_CLK_QCOM_GCC_SM6375_H
>> +
>
>
> Best regards,
> Krzysztof

\
 
 \ /
  Last update: 2022-07-20 21:37    [W:0.050 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site