lkml.org 
[lkml]   [2022]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/10] soc: qcom: icc-bwmon: add per-variant quirks
    Date
    BWMON v5 lacks global interrupt registers.  Other BWMON versions differ
    as well, so add quirks for easier customization of code flow.

    Cc: Rajendra Nayak <quic_rjendra@quicinc.com>
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    ---
    drivers/soc/qcom/icc-bwmon.c | 18 +++++++++++++-----
    1 file changed, 13 insertions(+), 5 deletions(-)

    diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
    index a3bebd4f0c95..63c0aea14c34 100644
    --- a/drivers/soc/qcom/icc-bwmon.c
    +++ b/drivers/soc/qcom/icc-bwmon.c
    @@ -101,6 +101,9 @@

    #define BWMON_V4_ZONE_MAX(zone) (0x2e0 + 4 * (zone))

    +/* Quirks for specific BWMON types */
    +#define BWMON_HAS_GLOBAL_IRQ BIT(0)
    +
    enum bwmon_fields {
    F_GLOBAL_IRQ_STATUS,
    F_GLOBAL_IRQ_CLEAR,
    @@ -138,6 +141,7 @@ struct icc_bwmon_data {
    unsigned int default_lowbw_kbps;
    u8 zone1_thres_count;
    u8 zone3_thres_count;
    + unsigned int quirks;

    const struct regmap_config *regmap_cfg;
    const struct reg_field *regmap_fields;
    @@ -274,14 +278,16 @@ static void bwmon_clear_irq(struct icc_bwmon *bwmon)
    * interrupt is cleared.
    */
    regmap_field_force_write(bwmon->regs[F_IRQ_CLEAR], BWMON_IRQ_ENABLE_MASK);
    - regmap_field_force_write(bwmon->regs[F_GLOBAL_IRQ_CLEAR],
    - BWMON_V4_GLOBAL_IRQ_ENABLE_ENABLE);
    + if (bwmon->data->quirks & BWMON_HAS_GLOBAL_IRQ)
    + regmap_field_force_write(bwmon->regs[F_GLOBAL_IRQ_CLEAR],
    + BWMON_V4_GLOBAL_IRQ_ENABLE_ENABLE);
    }

    static void bwmon_disable(struct icc_bwmon *bwmon)
    {
    /* Disable interrupts. Strict ordering, see bwmon_clear_irq(). */
    - regmap_field_write(bwmon->regs[F_GLOBAL_IRQ_ENABLE], 0x0);
    + if (bwmon->data->quirks & BWMON_HAS_GLOBAL_IRQ)
    + regmap_field_write(bwmon->regs[F_GLOBAL_IRQ_ENABLE], 0x0);
    regmap_field_write(bwmon->regs[F_IRQ_ENABLE], 0x0);

    /*
    @@ -294,8 +300,9 @@ static void bwmon_disable(struct icc_bwmon *bwmon)
    static void bwmon_enable(struct icc_bwmon *bwmon, unsigned int irq_enable)
    {
    /* Enable interrupts */
    - regmap_field_write(bwmon->regs[F_GLOBAL_IRQ_ENABLE],
    - BWMON_V4_GLOBAL_IRQ_ENABLE_ENABLE);
    + if (bwmon->data->quirks & BWMON_HAS_GLOBAL_IRQ)
    + regmap_field_write(bwmon->regs[F_GLOBAL_IRQ_ENABLE],
    + BWMON_V4_GLOBAL_IRQ_ENABLE_ENABLE);
    regmap_field_write(bwmon->regs[F_IRQ_ENABLE], irq_enable);

    /* Enable bwmon */
    @@ -547,6 +554,7 @@ static const struct icc_bwmon_data msm8998_bwmon_data = {
    .default_lowbw_kbps = 0,
    .zone1_thres_count = 16,
    .zone3_thres_count = 1,
    + .quirks = BWMON_HAS_GLOBAL_IRQ,
    .regmap_fields = msm8998_bwmon_reg_fields,
    .regmap_cfg = &msm8998_bwmon_regmap_cfg,
    };
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-07-20 21:29    [W:4.786 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site