Messages in this thread | | | From | LemmyHuang <> | Subject | Re: [PATCH net-next] tcp: fix condition for increasing pingpong count | Date | Wed, 20 Jul 2022 14:47:11 +0800 |
| |
At 2022-07-20 08:49:15, "Jakub Kicinski" <kuba@kernel.org> wrote: > On Tue, 19 Jul 2022 21:01:37 +0800 LemmyHuang wrote: >> - if (before(tp->lsndtime, icsk->icsk_ack.lrcvtime) && >> + if ((tp->lsndtime <= icsk->icsk_ack.lrcvtime) && > > Are you sure you don't need to take care of the values wrapping? > before() does that. You may want !after() if you want to allow equal.
Yeap, I will switch to that in v2. Thank you!
| |