Messages in this thread | | | From | Rob Clark <> | Date | Wed, 20 Jul 2022 10:57:21 -0700 | Subject | Re: [PATCH v2 09/13] drm/gem: Add LRU/shrinker helper |
| |
On Tue, Jul 19, 2022 at 11:56 AM Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote: > > On 7/19/22 20:18, Rob Clark wrote: > > +void > > +drm_gem_lru_move_tail_locked(struct drm_gem_lru *lru, struct drm_gem_object *obj) > > +{ > > + WARN_ON(!mutex_is_locked(lru->lock)); > > Nit: What about lockdep_assert_held_once(&lru->lock->base)) ?
ahh, good point.. I've switched it locally
BR, -R
> Otherwise, looks good! I'll use it for the DRM-SHMEM shrinker after > completing the work on the dma-buf locks. > > Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> > > -- > Best regards, > Dmitry
| |