Messages in this thread | | | Date | Wed, 20 Jul 2022 09:12:44 -0700 | Subject | Re: [PATCH] misc: bcm-vk: Specify the minimum number of IRQ vecs | From | Scott Branden <> |
| |
Hi Breno,
On 2022-07-19 05:23, Breno Leitao wrote: > From: Breno Leitao <leitao@debian.org> > > During bcm_vk_probe(), pci_alloc_irq_vectors() is called passing the > number of IRQ vectors as 1, but, later, check how many IRQ vectors it > got, and fails if it is smaller than VK_MSIX_IRQ_MIN_REQ. > > The most appropriated way to do it is setting the 'min_vecs' param as > VK_MSIX_IRQ_MIN_REQ, instead of one. pci_alloc_irq_vectors() should > know the requirements when called. Yes, the end result is no operational change before or after this commit. > > The test was done by just loading this module on a machine with a > Valkyrie offload engine > > Signed-off-by: Breno Leitao <leitao@debian.org> Acked-by: Scott Branden <scott.branden@broadcom.com> > --- > drivers/misc/bcm-vk/bcm_vk_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c > index a16b99bdaa13..bedab17884b8 100644 > --- a/drivers/misc/bcm-vk/bcm_vk_dev.c > +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c > @@ -1339,7 +1339,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > pci_set_drvdata(pdev, vk); > > irq = pci_alloc_irq_vectors(pdev, > - 1, > + VK_MSIX_IRQ_MIN_REQ, > VK_MSIX_IRQ_MAX, > PCI_IRQ_MSI | PCI_IRQ_MSIX); > [unhandled content-type:application/pkcs7-signature] | |