Messages in this thread | | | Date | Wed, 20 Jul 2022 16:45:32 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 RESEND 0/6] Add support for upcoming chips to k10temp and amd_nb |
| |
On Tue, Jul 19, 2022 at 02:52:50PM -0500, Mario Limonciello wrote: > This series started as what looked like a correction to previous > commits, but I missed that the previous commits were for a different > family with the same chip models. So while fixing up the series I also > noticed that a few upcoming chips have new PCIe IDs and CCD offsets not > yet supported, so add them to amd_nb/k10temp. > > v2->v3 > * Pick up tags > * Group "ROOT" PCI IDs with others in patches 2 and 3. > v1->v2: > * Correct commit messages > * Add more missing chips and offsets > * since so much changed, do not include Bjorn's Ack. > > V3 original submission: > * https://lore.kernel.org/lkml/20220613192956.4911-1-mario.limonciello@amd.com/#t > > Mario Limonciello (6): > x86/amd_nb: Add AMD Family 17h A0-AF IDs > x86/amd_nb: Add Family 19h model 70h-7Fh IDs > x86/amd_nb: Add Family 19h model 60h-6Fh IDs > hwmon: (k10temp): Add support for family 17h models A0h-AFh > hwmon: (k10temp): Add support for family 19h models 70h-7Fh > hwmon: (k10temp): Add support for family 19h models 60h-6Fh
Is there any particular reason why those are split into such small pieces?
I'd expect one patch adding all PCI IDs and a second patch doing the k10temp changes.
If no particular reason, I'll compact them all 6 into 2.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |