lkml.org 
[lkml]   [2022]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 27/35] perf tools: Add perf_event__is_guest()
    Em Tue, Jul 19, 2022 at 06:11:47PM -0700, Ian Rogers escreveu:
    > On Mon, Jul 11, 2022 at 2:33 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
    > >
    > > Add a helper function to determine if an event is a guest event.
    > >
    > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    > > ---
    > > tools/perf/util/event.h | 21 +++++++++++++++++++++
    > > 1 file changed, 21 insertions(+)
    > >
    > > diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
    > > index a660f304f83c..a7b0931d5137 100644
    > > --- a/tools/perf/util/event.h
    > > +++ b/tools/perf/util/event.h
    >
    > Would this be better under tools/lib/perf ?

    In general I think we should move things to libperf when a user requests
    it, i.e. it'll be needed in a tool that uses libperf.

    - Arnaldo

    > Thanks,
    > Ian
    >
    > > @@ -484,4 +484,25 @@ void arch_perf_synthesize_sample_weight(const struct perf_sample *data, __u64 *a
    > > const char *arch_perf_header_entry(const char *se_header);
    > > int arch_support_sort_key(const char *sort_key);
    > >
    > > +static inline bool perf_event_header__cpumode_is_guest(u8 cpumode)
    > > +{
    > > + return cpumode == PERF_RECORD_MISC_GUEST_KERNEL ||
    > > + cpumode == PERF_RECORD_MISC_GUEST_USER;
    > > +}
    > > +
    > > +static inline bool perf_event_header__misc_is_guest(u16 misc)
    > > +{
    > > + return perf_event_header__cpumode_is_guest(misc & PERF_RECORD_MISC_CPUMODE_MASK);
    > > +}
    > > +
    > > +static inline bool perf_event_header__is_guest(const struct perf_event_header *header)
    > > +{
    > > + return perf_event_header__misc_is_guest(header->misc);
    > > +}
    > > +
    > > +static inline bool perf_event__is_guest(const union perf_event *event)
    > > +{
    > > + return perf_event_header__is_guest(&event->header);
    > > +}
    > > +
    > > #endif /* __PERF_RECORD_H */
    > > --
    > > 2.25.1
    > >

    --

    - Arnaldo

    \
     
     \ /
      Last update: 2022-07-20 16:08    [W:3.700 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site