Messages in this thread | | | Date | Wed, 20 Jul 2022 09:46:29 +0200 | Subject | Re: [PATCH] usb: trancevibrator: simplify tv_probe | From | Christophe JAILLET <> |
| |
Le 20/07/2022 à 09:23, Dongliang Mu a écrit : > From: Dongliang Mu <mudongliangabcd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > The function tv_probe does not need to invoke kfree when the > allocation fails. So let's simplify the code of tv_probe. > Another change is to remove a redundant space. > > Signed-off-by: Dongliang Mu <mudongliangabcd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > drivers/usb/misc/trancevibrator.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c > index 26baba3ab7d7..30d4d774d448 100644 > --- a/drivers/usb/misc/trancevibrator.c > +++ b/drivers/usb/misc/trancevibrator.c > @@ -84,29 +84,22 @@ static int tv_probe(struct usb_interface *interface, > { > struct usb_device *udev = interface_to_usbdev(interface); > struct trancevibrator *dev; > - int retval; > > dev = kzalloc(sizeof(struct trancevibrator), GFP_KERNEL); > - if (!dev) { > - retval = -ENOMEM; > - goto error; > - } > + if (!dev) > + return -ENOMEM; > > dev->udev = usb_get_dev(udev); > usb_set_intfdata(interface, dev); > > return 0;
Hi,
looks like:
error: kfree(dev); return retval;
at the end of the function can be removed as-well.
Just my 2c.
CJ
| |