| Date | Wed, 20 Jul 2022 23:51:59 +0000 | From | Sean Christopherson <> | Subject | Re: [PATCH v2 03/11] KVM: x86: emulator: remove assign_eip_near/far |
| |
On Tue, Jun 21, 2022, Maxim Levitsky wrote: > Now the assign_eip_far just updates the emulation mode in addition to > updating the rip, it doesn't make sense to keep that function. > > Move mode update to the callers and remove these functions.
I disagree, IMO there's a lot of value in differentiating between near and far. Yeah, the assign_eip_near() wrapper is kinda silly, but have that instead of a bare assign_eip() documents that e.g. jmp_rel() is a near jump and that it's not missing an update.
|