lkml.org 
[lkml]   [2022]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 3/3] asm-generic: Add new pci.h and use it
    On Wed, Jul 20, 2022 at 10:19:34PM +0900, Stafford Horne wrote:
    > The asm/pci.h used for many newer architectures share similar
    > definitions. Move the common parts to asm-generic/pci.h to allow for
    > sharing code.
    >
    > One thing to note:
    >
    > - ARCH_GENERIC_PCI_MMAP_RESOURCE, csky does not define this so we
    > undefine it after including asm-generic/pci.h. Why doesn't csky
    > define it?
    >
    > Suggested-by: Arnd Bergmann <arnd@arndb.de>
    > Link: https://lore.kernel.org/lkml/CAK8P3a0JmPeczfmMBE__vn=Jbvf=nkbpVaZCycyv40pZNCJJXQ@mail.gmail.com/
    > Acked-by: Pierre Morel <pmorel@linux.ibm.com>
    > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
    > Signed-off-by: Stafford Horne <shorne@gmail.com>

    > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
    > index 0aebc3488c32..016eb6b46dc0 100644
    > --- a/arch/arm64/include/asm/pci.h
    > +++ b/arch/arm64/include/asm/pci.h

    > -extern int isa_dma_bridge_buggy;

    Shouldn't this go in the previous patch? The only definition of a
    isa_dma_bridge_buggy variable is in drivers/pci/pci.c, and it's under
    #ifdef CONFIG_X86_32.

    Same for csky, riscv, um?

    \
     
     \ /
      Last update: 2022-07-21 00:43    [W:3.112 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site