Messages in this thread | | | Date | Sat, 2 Jul 2022 14:59:37 -0700 | From | Yury Norov <> | Subject | Re: [PATCH 5/8] lib/cpumask: change return types to unsigned where appropriate |
| |
On Sat, Jul 02, 2022 at 03:00:19PM +0300, Andy Shevchenko wrote: > On Fri, Jul 01, 2022 at 05:54:27AM -0700, Yury Norov wrote: > > Switch return types to unsigned int where return values cannot be negative. > > ... > > > -int cpumask_any_and_distribute(const struct cpumask *src1p, > > +unsigned int cpumask_any_and_distribute(const struct cpumask *src1p, > > const struct cpumask *src2p); > > It breaks indentation of the second line.
I'd prefer to keep 2nd line untouched to not trash history for nothing.
> > ... > > > -int cpumask_next_and(int n, const struct cpumask *src1p, > > +unsigned int cpumask_next_and(int n, const struct cpumask *src1p, > > const struct cpumask *src2p) > > Ditto. > > And seems a lot of cases in the series like this. > > -- > With Best Regards, > Andy Shevchenko >
| |