[lkml]   [2022]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 2/4] module: panic: Taint the kernel when selftest modules load
On Sat, Jul 2, 2022 at 12:10 PM David Gow <> wrote:
> Taint the kernel with TAINT_TEST whenever a test module loads, by adding
> a new "TEST" module property, and setting it for all modules in the
> tools/testing directory. This property can also be set manually, for
> tests which live outside the tools/testing directory with:
> MODULE_INFO(test, "Y");
> Reviewed-by: Luis Chamberlain <>
> Signed-off-by: David Gow <>
> ---

I forgot the changelogs here. The only significant difference from v4
is the change from pr_warn() to pr_warn_once().

Changes since v4:
- Use pr_warn_once() to only log a warning the first time a module
taints the kernel with TAINT_TEST
- Loading lots of test modules is a common usecase, and this would
otherwise spam the logs too much.
- Thanks Luis.
- Remove a superfluous newline (Thanks Greg)
- Add Luis' Reviewed-by tag.

This patch was new in v4 of the series.
[unhandled content-type:application/pkcs7-signature]
 \ /
  Last update: 2022-07-02 06:46    [W:0.060 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site