lkml.org 
[lkml]   [2022]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf unwind: fix unitialized offset on aarch64
Em Fri, Jul 01, 2022 at 11:20:46AM -0700, Ivan Babrou escreveu:
> Commit dc2cf4ca866f uncovered the following issue on aarch64:
>
> util/unwind-libunwind-local.c: In function 'find_proc_info':
> util/unwind-libunwind-local.c:386:28: error: 'offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 386 | if (ofs > 0) {
> | ^
> util/unwind-libunwind-local.c:199:22: note: 'offset' was declared here
> 199 | u64 address, offset;
> | ^~~~~~
> util/unwind-libunwind-local.c:371:20: error: 'offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 371 | if (ofs <= 0) {
> | ^
> util/unwind-libunwind-local.c:199:22: note: 'offset' was declared here
> 199 | u64 address, offset;
> | ^~~~~~
> util/unwind-libunwind-local.c:363:20: error: 'offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 363 | if (ofs <= 0) {
> | ^
> util/unwind-libunwind-local.c:199:22: note: 'offset' was declared here
> 199 | u64 address, offset;
> | ^~~~~~
> In file included from util/libunwind/arm64.c:37:

Thanks, applied.

- Arnaldo


> Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
> Fixes: dc2cf4ca866f
> ---
> tools/perf/util/unwind-libunwind-local.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
> index 37622699c91a..eaa8fa4b34f3 100644
> --- a/tools/perf/util/unwind-libunwind-local.c
> +++ b/tools/perf/util/unwind-libunwind-local.c
> @@ -197,7 +197,7 @@ static int elf_section_address_and_offset(int fd, const char *name, u64 *address
> #ifndef NO_LIBUNWIND_DEBUG_FRAME
> static u64 elf_section_offset(int fd, const char *name)
> {
> - u64 address, offset;
> + u64 address, offset = 0;
>
> if (elf_section_address_and_offset(fd, name, &address, &offset))
> return 0;
> --
> 2.36.1

--

- Arnaldo

\
 
 \ /
  Last update: 2022-07-02 14:19    [W:0.697 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site