lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 130/167] net: sfp: fix memory leak in sfp_probe()
    Date
    From: Jianglei Nie <niejianglei2021@163.com>

    [ Upstream commit 0a18d802d65cf662644fd1d369c86d84a5630652 ]

    sfp_probe() allocates a memory chunk from sfp with sfp_alloc(). When
    devm_add_action() fails, sfp is not freed, which leads to a memory leak.

    We should use devm_add_action_or_reset() instead of devm_add_action().

    Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
    Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
    Link: https://lore.kernel.org/r/20220629075550.2152003-1-niejianglei2021@163.com
    Signed-off-by: Paolo Abeni <pabeni@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/phy/sfp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
    index 90dfefc1f5f8..028a5df5c538 100644
    --- a/drivers/net/phy/sfp.c
    +++ b/drivers/net/phy/sfp.c
    @@ -2504,7 +2504,7 @@ static int sfp_probe(struct platform_device *pdev)

    platform_set_drvdata(pdev, sfp);

    - err = devm_add_action(sfp->dev, sfp_cleanup, sfp);
    + err = devm_add_action_or_reset(sfp->dev, sfp_cleanup, sfp);
    if (err < 0)
    return err;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-19 14:43    [W:9.079 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site