lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 030/167] reset: Fix devm bulk optional exclusive control getter
    Date
    From: Serge Semin <Sergey.Semin@baikalelectronics.ru>

    [ Upstream commit a57f68ddc8865d59a19783080cc52fb4a11dc209 ]

    Most likely due to copy-paste mistake the device managed version of the
    denoted reset control getter has been implemented with invalid semantic,
    which can be immediately spotted by having "WARN_ON(shared && acquired)"
    warning in the system log as soon as the method is called. Anyway let's
    fix it by altering the boolean arguments passed to the
    __devm_reset_control_bulk_get() method from
    - shared = true, optional = false, acquired = true
    to
    + shared = false, optional = true, acquired = true
    That's what they were supposed to be in the first place (see the non-devm
    version of the same method: reset_control_bulk_get_optional_exclusive()).

    Fixes: 48d71395896d ("reset: Add reset_control_bulk API")
    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
    Link: https://lore.kernel.org/r/20220624141853.7417-2-Sergey.Semin@baikalelectronics.ru
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/linux/reset.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/linux/reset.h b/include/linux/reset.h
    index db0e6115a2f6..7bb583737528 100644
    --- a/include/linux/reset.h
    +++ b/include/linux/reset.h
    @@ -711,7 +711,7 @@ static inline int __must_check
    devm_reset_control_bulk_get_optional_exclusive(struct device *dev, int num_rstcs,
    struct reset_control_bulk_data *rstcs)
    {
    - return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, true, false, true);
    + return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, false, true, true);
    }

    /**
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-19 14:32    [W:4.161 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site