lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 090/112] ASoC: SOF: Intel: hda-loader: Clarify the cl_dsp_init() flow
    Date
    From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

    [ Upstream commit bbfef046c6613404c01aeb9e9928bebb78dd327a ]

    Update the comment for the cl_dsp_init() to clarify what is done by the
    function and use the chip->init_core_mask instead of BIT(0) when
    unstalling/running the init core.

    Complements: 2a68ff846164 ("ASoC: SOF: Intel: hda: Revisit IMR boot sequence")
    Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
    Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
    Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
    Link: https://lore.kernel.org/r/20220609085949.29062-4-peter.ujfalusi@linux.intel.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/sof/intel/hda-loader.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/sound/soc/sof/intel/hda-loader.c b/sound/soc/sof/intel/hda-loader.c
    index 347636a80b48..4012097a9d60 100644
    --- a/sound/soc/sof/intel/hda-loader.c
    +++ b/sound/soc/sof/intel/hda-loader.c
    @@ -79,9 +79,9 @@ static struct hdac_ext_stream *cl_stream_prepare(struct snd_sof_dev *sdev, unsig
    }

    /*
    - * first boot sequence has some extra steps. core 0 waits for power
    - * status on core 1, so power up core 1 also momentarily, keep it in
    - * reset/stall and then turn it off
    + * first boot sequence has some extra steps.
    + * power on all host managed cores and only unstall/run the boot core to boot the
    + * DSP then turn off all non boot cores (if any) is powered on.
    */
    static int cl_dsp_init(struct snd_sof_dev *sdev, int stream_tag)
    {
    @@ -115,7 +115,7 @@ static int cl_dsp_init(struct snd_sof_dev *sdev, int stream_tag)
    ((stream_tag - 1) << 9)));

    /* step 3: unset core 0 reset state & unstall/run core 0 */
    - ret = hda_dsp_core_run(sdev, BIT(0));
    + ret = hda_dsp_core_run(sdev, chip->init_core_mask);
    if (ret < 0) {
    if (hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS)
    dev_err(sdev->dev,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-19 14:26    [W:4.093 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site