lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 064/112] net: ftgmac100: Hold reference returned by of_get_child_by_name()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 49b9f431ff0d845a36be0b3ede35ec324f2e5fee ]

    In ftgmac100_probe(), we should hold the refernece returned by
    of_get_child_by_name() and use it to call of_node_put() for
    reference balance.

    Fixes: 39bfab8844a0 ("net: ftgmac100: Add support for DT phy-handle property")
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/faraday/ftgmac100.c | 15 ++++++++++++++-
    1 file changed, 14 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
    index eea4bd3116e8..969af4dd6405 100644
    --- a/drivers/net/ethernet/faraday/ftgmac100.c
    +++ b/drivers/net/ethernet/faraday/ftgmac100.c
    @@ -1747,6 +1747,19 @@ static int ftgmac100_setup_clk(struct ftgmac100 *priv)
    return rc;
    }

    +static bool ftgmac100_has_child_node(struct device_node *np, const char *name)
    +{
    + struct device_node *child_np = of_get_child_by_name(np, name);
    + bool ret = false;
    +
    + if (child_np) {
    + ret = true;
    + of_node_put(child_np);
    + }
    +
    + return ret;
    +}
    +
    static int ftgmac100_probe(struct platform_device *pdev)
    {
    struct resource *res;
    @@ -1860,7 +1873,7 @@ static int ftgmac100_probe(struct platform_device *pdev)

    /* Display what we found */
    phy_attached_info(phy);
    - } else if (np && !of_get_child_by_name(np, "mdio")) {
    + } else if (np && !ftgmac100_has_child_node(np, "mdio")) {
    /* Support legacy ASPEED devicetree descriptions that decribe a
    * MAC with an embedded MDIO controller but have no "mdio"
    * child node. Automatically scan the MDIO bus for available
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-19 14:26    [W:4.050 / U:0.732 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site