lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 021/112] nilfs2: fix incorrect masking of permission flags for symlinks
    Date
    From: Ryusuke Konishi <konishi.ryusuke@gmail.com>

    commit 5924e6ec1585445f251ea92713eb15beb732622a upstream.

    The permission flags of newly created symlinks are wrongly dropped on
    nilfs2 with the current umask value even though symlinks should have 777
    (rwxrwxrwx) permissions:

    $ umask
    0022
    $ touch file && ln -s file symlink; ls -l file symlink
    -rw-r--r--. 1 root root 0 Jun 23 16:29 file
    lrwxr-xr-x. 1 root root 4 Jun 23 16:29 symlink -> file

    This fixes the bug by inserting a missing check that excludes
    symlinks.

    Link: https://lkml.kernel.org/r/1655974441-5612-1-git-send-email-konishi.ryusuke@gmail.com
    Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
    Reported-by: Tommy Pettersson <ptp@lysator.liu.se>
    Reported-by: Ciprian Craciun <ciprian.craciun@gmail.com>
    Tested-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/nilfs2/nilfs.h | 3 +++
    1 file changed, 3 insertions(+)

    --- a/fs/nilfs2/nilfs.h
    +++ b/fs/nilfs2/nilfs.h
    @@ -198,6 +198,9 @@ static inline int nilfs_acl_chmod(struct

    static inline int nilfs_init_acl(struct inode *inode, struct inode *dir)
    {
    + if (S_ISLNK(inode->i_mode))
    + return 0;
    +
    inode->i_mode &= ~current_umask();
    return 0;
    }

    \
     
     \ /
      Last update: 2022-07-19 14:22    [W:4.029 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site