lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 61/71] soc: ixp4xx/npe: Fix unused match warning
    Date
    From: Linus Walleij <linus.walleij@linaro.org>

    [ Upstream commit 620f83b8326ce9706b1118334f0257ae028ce045 ]

    The kernel test robot found this inconsistency:

    drivers/soc/ixp4xx/ixp4xx-npe.c:737:34: warning:
    'ixp4xx_npe_of_match' defined but not used [-Wunused-const-variable=]
    737 | static const struct of_device_id ixp4xx_npe_of_match[] = {

    This is because the match is enclosed in the of_match_ptr()
    which compiles into NULL when OF is disabled and this
    is unnecessary.

    Fix it by dropping of_match_ptr() around the match.

    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Link: https://lore.kernel.org/r/20220626074315.61209-1-linus.walleij@linaro.org'
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/ixp4xx/ixp4xx-npe.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/soc/ixp4xx/ixp4xx-npe.c b/drivers/soc/ixp4xx/ixp4xx-npe.c
    index 6065aaab6740..8482a4892b83 100644
    --- a/drivers/soc/ixp4xx/ixp4xx-npe.c
    +++ b/drivers/soc/ixp4xx/ixp4xx-npe.c
    @@ -735,7 +735,7 @@ static const struct of_device_id ixp4xx_npe_of_match[] = {
    static struct platform_driver ixp4xx_npe_driver = {
    .driver = {
    .name = "ixp4xx-npe",
    - .of_match_table = of_match_ptr(ixp4xx_npe_of_match),
    + .of_match_table = ixp4xx_npe_of_match,
    },
    .probe = ixp4xx_npe_probe,
    .remove = ixp4xx_npe_remove,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-19 14:19    [W:4.035 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site