lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 19/43] icmp: Fix a data-race around sysctl_icmp_ratemask.
    Date
    From: Kuniyuki Iwashima <kuniyu@amazon.com>

    [ Upstream commit 1ebcb25ad6fc3d50fca87350acf451b9a66dd31e ]

    While reading sysctl_icmp_ratemask, it can be changed concurrently.
    Thus, we need to add READ_ONCE() to its reader.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/ipv4/icmp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
    index e384926de46f..1748dfb1dc0a 100644
    --- a/net/ipv4/icmp.c
    +++ b/net/ipv4/icmp.c
    @@ -295,7 +295,7 @@ static bool icmpv4_mask_allow(struct net *net, int type, int code)
    return true;

    /* Limit if icmp type is enabled in ratemask. */
    - if (!((1 << type) & net->ipv4.sysctl_icmp_ratemask))
    + if (!((1 << type) & READ_ONCE(net->ipv4.sysctl_icmp_ratemask)))
    return true;

    return false;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-19 14:00    [W:6.790 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site