lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 00/18] KVM nVHE Hypervisor stack unwinder
    On Fri, 15 Jul 2022 07:10:09 +0100,
    Kalesh Singh <kaleshsingh@google.com> wrote:
    >
    > Hi all,
    >
    > This is v4 of the series adding support for nVHE hypervisor stacktraces;
    > and is based on arm64 for-next/stacktrace.
    >
    > Thanks all for your feedback on previous revisions. Mark Brown, I
    > appreciate your Reviewed-by on the v3, I have dropped the tags in this
    > new verision since I think the series has changed quite a bit.
    >
    > The previous versions were posted at:
    > v3: https://lore.kernel.org/r/20220607165105.639716-1-kaleshsingh@google.com/
    > v2: https://lore.kernel.org/r/20220502191222.4192768-1-kaleshsingh@google.com/
    > v1: https://lore.kernel.org/r/20220427184716.1949239-1-kaleshsingh@google.com/
    >
    > The main updates in this version are to address concerens from Marc on the
    > memory usage and reusing the common code by refactoring into a shared header.

    Overall, the series looks better. I've pointed out a few things that
    need changing, but my overall gripe is around the abuse the
    stacktrace/nvhe.h as a dumping ground. A lot of the code there could
    be pushed to handle_exit.c (or some other compilation unit).

    I've pushed an example of a 10 minutes refactor in my tree
    (kvm-arm64/nvhe-stacktrace), and I'm sure these are the lowest hanging
    fruits.

    Thanks,

    M.

    --
    Without deviation from the norm, progress is not possible.

    \
     
     \ /
      Last update: 2022-07-19 12:43    [W:4.116 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site