Messages in this thread | | | Date | Tue, 19 Jul 2022 11:23:47 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH v2 -next 2/2] irqdomain: Replace revmap_direct_max_irq field with hwirq_max field |
| |
On Tue, 19 Jul 2022 07:36:41 +0100, Xu Qiang <xuqiang36@huawei.com> wrote: > > In commit "4f86a06e2d6e irqdomain: Make normal and nomap irqdomains exclusive", > use revmap_size field instead of revmap_direct_max_irq. revmap_size field > originally indicates the maximum hwirq of linear Mapping. This results in > revmap_size having two different layers of meaning that can be confusing. > > This patch optimization point is to solve this confusion point. During > direct mapping, the values of hwirq_max and revmap_direct_max_irq are the same > and have the same meanings. They both indicate the maximum hwirq supported by > direct Mapping. The optimization method is to delete revmap_direct_max_irq > field and use hwirq_max instead of revmap_direct_max_irq. > > Signed-off-by: Xu Qiang <xuqiang36@huawei.com>
You keep referencing revmap_direct_max_irq, which is long gone.
How about instead:
<commit> NOMAP irq domains use the revmap_size field to indicate the maximum hwirq number the domain accepts. This is a bit confusing as revmap_size is usually used to indicate the size of the revmap array, which a NOMAP domain doesn't have.
Instead, use the hwirq_max field which has the correct semantics, and keep revmap_size to 0 for a NOMAP domain. </commit>
If you agree with this, please say so (no need to respin for this).
Thanks,
M.
-- Without deviation from the norm, progress is not possible.
| |