lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] clk/ti/adpll: remove useless comparison in ti_adpll_free_resources()
Date
Local variable 'ac' is initialized by an address
of field of ti_adpll_data, so it does not make
sense to compare 'ac' with NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Strachuk <strochuk@ispras.ru>
Fixes: 21330497f303 ("clk: ti: Add support for dm814x ADPLL")
---
drivers/clk/ti/adpll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
index 962502ca7ff0..7207915f9440 100644
--- a/drivers/clk/ti/adpll.c
+++ b/drivers/clk/ti/adpll.c
@@ -772,7 +772,7 @@ static void ti_adpll_free_resources(struct ti_adpll_data *d)
for (i = TI_ADPLL_M3; i >= 0; i--) {
struct ti_adpll_clock *ac = &d->clocks[i];

- if (!ac || IS_ERR_OR_NULL(ac->clk))
+ if (IS_ERR_OR_NULL(ac->clk))
continue;
if (ac->cl)
clkdev_drop(ac->cl);
--
2.25.1
\
 
 \ /
  Last update: 2022-07-19 12:24    [W:0.027 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site