lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next v3 1/3] devlink: introduce framework for selftests
Hi Jakub,

On Tue, Jul 19, 2022 at 9:03 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 18 Jul 2022 11:50:30 +0530 Vikas Gupta wrote:
> > + for (i = 1; i < DEVLINK_SELFTEST_ATTR_MAX + 1; i++) {
> > + u8 res;
> > +
> > + if (nla_get_flag(tb[i])) {
> > + res = devlink->ops->selftest_run(devlink, i,
>
> Shouldn't we selftest_check() first to make sure the driver supports
> given test?
Yes, I`ll add selftest_check() here rather than letting the driver return SKIP.

Thanks,
Vikas

>
> > + [DEVLINK_ATTR_SELFTESTS_INFO] = { .type = NLA_NESTED },
>
> ... = NLA_POLICY_NESTED(devlink_selftest_nl_policy),
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2022-07-19 12:19    [W:1.218 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site