Messages in this thread | | | Date | Tue, 19 Jul 2022 11:43:51 +0200 | Subject | Re: [PATCH v4 2/2] dt-bindings: fpga: add binding doc for ecp5-spi fpga mgr | From | Krzysztof Kozlowski <> |
| |
On 19/07/2022 11:25, Ivan Bornyakov wrote: > Add Device Tree Binding doc for Lattice ECP5 FPGA manager using slave > SPI to load .bit formatted uncompressed bitstream image. > > Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru> > --- > .../bindings/fpga/lattice,ecp5-fpga-mgr.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml > > diff --git a/Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml > new file mode 100644 > index 000000000000..7d2bd386b533 > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/fpga/lattice,ecp5-fpga-mgr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lattice ECP5 Slave SPI FPGA manager.
Skip trailing dot.
> + > +maintainers: > + - Ivan Bornyakov <i.bornyakov@metrotek.ru> > + > +description: > + Lattice ECP5 sysCONFIG port, which is used for device configuration, among > + others, have Slave Serial Peripheral Interface. The driver is to program
s/The driver is to// Do not refer to driver implementation in the bindings. The entire bindings and description field is about the hardware, not driver.
With the changes: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |