lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [net-next PATCH v4 4/5] net: ethernet: stmicro: stmmac: generate stmmac dma conf before open
    On Tue, 19 Jul 2022 03:32:18 +0200 Christian Marangi wrote:
    > Rework the driver to generate the stmmac dma_conf before stmmac_open.
    > This permits a function to first check if it's possible to allocate a
    > new dma_config and then pass it directly to __stmmac_open and "open" the
    > interface with the new configuration.

    You missed one kdoc:

    > @@ -1711,9 +1744,11 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags)
    > * and allocates the socket buffers. It supports the chained and ring
    > * modes.
    > */
    > -static int __init_dma_tx_desc_rings(struct stmmac_priv *priv, u32 queue)
    > +static int __init_dma_tx_desc_rings(struct stmmac_priv *priv,
    > + struct stmmac_dma_conf *dma_conf,
    > + u32 queue)
    > {

    drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1750: warning: Function parameter or member 'dma_conf' not described in '__init_dma_tx_desc_rings'

    \
     
     \ /
      Last update: 2022-07-20 03:07    [W:3.521 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site