lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 bpf-next 2/4] ftrace: allow IPMODIFY and DIRECT ops on the same function
On Tue, 19 Jul 2022 23:24:35 +0000
Song Liu <songliubraving@fb.com> wrote:

> Actually, we cannot blindly lock direct_mutex here, as
> register_ftrace_direct() already locks it before calling
> register_ftrace_function(). We still need the if (IPMODIFY)
> check.

Let's not play games with this then.

Create a register_ftrace_function_nolock()

and use that for register_ftrace_direct().

Otherwise it's going to be a nightmare to keep track of.

-- Steve

\
 
 \ /
  Last update: 2022-07-20 01:28    [W:0.065 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site