lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 3/3] drm/panel-edp: Fix variable typo when saving hpd absent delay from DT
    Hi,

    On Tue, Jul 19, 2022 at 1:39 PM Nícolas F. R. A. Prado
    <nfraprado@collabora.com> wrote:
    >
    > The value read from the "hpd-absent-delay-ms" property in DT was being
    > saved to the wrong variable, overriding the hpd_reliable delay. Fix the
    > typo.
    >
    > Fixes: 5540cf8f3e8d ("drm/panel-edp: Implement generic "edp-panel"s probed by EDID")
    > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
    > ---
    >
    > drivers/gpu/drm/panel/panel-edp.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
    > index 152e00eb846f..b3536d8600f4 100644
    > --- a/drivers/gpu/drm/panel/panel-edp.c
    > +++ b/drivers/gpu/drm/panel/panel-edp.c
    > @@ -738,7 +738,7 @@ static int generic_edp_panel_probe(struct device *dev, struct panel_edp *panel)
    > of_property_read_u32(dev->of_node, "hpd-reliable-delay-ms", &reliable_ms);
    > desc->delay.hpd_reliable = reliable_ms;
    > of_property_read_u32(dev->of_node, "hpd-absent-delay-ms", &absent_ms);
    > - desc->delay.hpd_reliable = absent_ms;
    > + desc->delay.hpd_absent = absent_ms;

    Well that's embarrassing. In the end I never used any of these
    properties for anything shipping since HPD was always hooked up on
    later boards and the only board that needed "hpd_reliable" never ended
    up switching to the generic "edp-panel".

    Reviewed-by: Douglas Anderson <dianders@chromium.org>

    I'll apply this right away to drm-misc-fixes.

    \
     
     \ /
      Last update: 2022-07-20 00:46    [W:3.794 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site