Messages in this thread | | | Date | Tue, 19 Jul 2022 16:22:40 +0800 (CST) | From | "Liang He" <> | Subject | Re:Re: [PATCH] memory: of: Add of_node_put() when breaking out of for_each_child_of_node() |
| |
At 2022-07-19 16:18:31, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> wrote: >On 16/07/2022 04:50, Liang He wrote: >> In of_get_ddr_timings() and of_lpddr3_get_ddr_timings(), we should >> add the of_node_put() when breaking out of for_each_child_of_node() >> as it will automatically increase and decrease the refcount. >> > >Thank you for your patch. There is something to discuss/improve. > >> Fixes: 976897dd96db ("memory: Extend of_memory with LPDDR3 support") >> Fixes: e6b42eb6a66c ("memory: emif: add device tree support to emif driver") > >Please split the patches into two separate fixes. > >> Signed-off-by: Liang He <windhl@126.com> >> --- >> drivers/memory/of_memory.c | 2 ++ >> 1 file changed, 2 insertions(+) >Best regards, >Krzysztof
I will do that soon.
Thanks, Liang
| |