lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] memory: of: Add of_node_put() when breaking out of for_each_child_of_node()
From
On 16/07/2022 04:50, Liang He wrote:
> In of_get_ddr_timings() and of_lpddr3_get_ddr_timings(), we should
> add the of_node_put() when breaking out of for_each_child_of_node()
> as it will automatically increase and decrease the refcount.
>

Thank you for your patch. There is something to discuss/improve.

> Fixes: 976897dd96db ("memory: Extend of_memory with LPDDR3 support")
> Fixes: e6b42eb6a66c ("memory: emif: add device tree support to emif driver")

Please split the patches into two separate fixes.

> Signed-off-by: Liang He <windhl@126.com>
> ---
> drivers/memory/of_memory.c | 2 ++
> 1 file changed, 2 insertions(+)
Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-07-19 10:20    [W:0.601 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site