Messages in this thread | | | Date | Tue, 19 Jul 2022 16:47:31 -0500 | From | Bjorn Helgaas <> | Subject | Re: build failure of next-20220718 due to 'imx6_pcie_host_exit' defined but not used |
| |
On Tue, Jul 19, 2022 at 11:16:40PM +0200, Arnd Bergmann wrote: > On Tue, Jul 19, 2022 at 11:04 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > > > commit 0e4daeaa52ca ("PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()") > > Author: Bjorn Helgaas <bhelgaas@google.com> > > Date: Tue Jul 19 15:50:18 2022 -0500 > > > > PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS() > > > > Replace SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() with NOIRQ_SYSTEM_SLEEP_PM_OPS(), > > which has the advantage that the compiler always sees the PM callbacks as > > referenced, so they don't need to be wrapped with "#ifdef CONFIG_PM_SLEEP" > > or tagged with "__maybe_unused" to avoid "defined but not used" warnings. > > > > See 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones"). > > > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Thanks! And sorry about being crabby earlier. If this allows us to get rid of those #ifdefs and __maybe_unused, it's a great improvement!
Bjorn
| |