lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ARM: dts: lan966x: Add gpio-restart
The 07/19/2022 07:52, Claudiu Beznea - M18063 wrote:
> On 19.07.2022 00:29, Horatiu Vultur wrote:
> > The pcb8291 can be rebooted by toggling the GPIO 56. Therefore enable
> > this in DT.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > arch/arm/boot/dts/lan966x-pcb8291.dts | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > index d56d2054c38d..02fbf7371a8d 100644
> > --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> > +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > @@ -16,6 +16,12 @@ chosen {
> > aliases {
> > serial0 = &usart3;
> > };
> > +
> > + gpio-restart {
> > + compatible = "gpio-restart";
> > + gpios = <&gpio 56 GPIO_ACTIVE_LOW>;
>
> Could you, please, add also pinctrl-names, pinctrl-0 for this gpio?

I am not sure I need to set pinctrl-names and pinctrl-0.
Because I don't need to setup any function for GPIO 56 to be able to
reset.
It is something similar sparx5 [1].

[1] https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi#L10

>
> > + priority = <200>;
> > + };
> > };
> >
> > &gpio {
>

--
/Horatiu

\
 
 \ /
  Last update: 2022-07-19 22:01    [W:0.083 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site