lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
From
On 19/07/2022 11:58, Peng Fan wrote:
>>> + interconnects:
>>> + items:
>>> + - description: G1 decoder interconnect
>>> + - description: G2 decoder interconnect
>>> + - description: VC8000E encoder interconnect
>>> +
>>> + interconnect-names:
>>> + items:
>>> + - const: g1
>>> + - const: g2
>>> + - const: vc8000e
>>
>> Include interconnects+names in list of all properties and disallow them for
>> other variants.
>
> I not understand well about
> " Include interconnects+names in list of all properties ", could you please
> explain a bit more?
>
> And there is already an "if" to check whether the
> compatible contains " fsl,imx8mp-vpu-blk-ctrl" to make sure the interconnect
> valid for i.MX8MP, so it is not valid to other variants.

Defining properties in some if: clause is not really readable and
maintainable. The properties should be defined in top-level properties:.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-07-19 21:10    [W:0.084 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site