lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 09/13] drm/gem: Add LRU/shrinker helper
    From
    On 7/19/22 20:18, Rob Clark wrote:
    > +void
    > +drm_gem_lru_move_tail_locked(struct drm_gem_lru *lru, struct drm_gem_object *obj)
    > +{
    > + WARN_ON(!mutex_is_locked(lru->lock));

    Nit: What about lockdep_assert_held_once(&lru->lock->base)) ?

    Otherwise, looks good! I'll use it for the DRM-SHMEM shrinker after
    completing the work on the dma-buf locks.

    Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

    --
    Best regards,
    Dmitry

    \
     
     \ /
      Last update: 2022-07-19 21:02    [W:2.846 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site