lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 bpf-next 2/4] ftrace: allow IPMODIFY and DIRECT ops on the same function
On Tue, 19 Jul 2022 14:28:56 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> > + /* Cannot have two ipmodify on same rec */
> > + if (is_ipmodify)
> > + goto rollback;
> > +
>
> I might add a
>
> FTRACE_WARN_ON(rec->flags &
> FTRACE_FL_DIRECT);

Bah, my email client line wrapped this. It was suppose to be:

FTRACE_WARN_ON(rec->flags & FTRACE_FL_DIRECT);

Just so you don't think I wanted that initial formatting ;-)

-- Steve

>
> Just to be safe.
>
> That is, if this is true, we are adding a new direct function to a record
> that already has one.

\
 
 \ /
  Last update: 2022-07-19 20:41    [W:0.066 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site