Messages in this thread | | | Date | Tue, 19 Jul 2022 10:57:31 -0700 | From | Luis Chamberlain <> | Subject | Re: [PATCH] module: kunit: Load .kunit_test_suites section when CONFIG_KUNIT=m |
| |
On Wed, Jul 13, 2022 at 08:52:20AM +0800, David Gow wrote: > The new KUnit module handling has KUnit test suites listed in a > .kunit_test_suites section of each module. This should be loaded when > the module is, but at the moment this only happens if KUnit is built-in. >
This commit log does not describe what functionality is broken exactly without this commit. What functionality from kunit is provided when .kunit_test_suites is available?
> Also load this when KUnit is enabled as a module: it'll not be usable > unless KUnit is loaded,
What benefit is there to load a kunit module without kunit?
> but such modules are likely to depend on KUnit > anyway, so it's unlikely to ever be loaded needlessly. > > Fixes: 3d6e44623841 ("kunit: unify module and builtin suite definitions") > Signed-off-by: David Gow <davidgow@google.com>
| |