Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 19 Jul 2022 09:27:02 -0700 | Subject | Re: [patch 00/38] x86/retbleed: Call depth tracking mitigation |
| |
On Tue, Jul 19, 2022 at 1:26 AM David Laight <David.Laight@aculab.com> wrote: > > Shouldn't it be testing the value the caller supplied?
Actually, I'm just all confused.
All that verification code is *in* the caller, before the call - to verify that the target looks fine.
I think I was confused by the hash thunk above the function also being generated with a "cmpl $hash". And I don't even know why that is, and why it wasn't just the bare constant.
Linus
| |